Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/browser/service/service_process_control.cc

Issue 3704003: Fix crash on launch when remoting lab is turned on on Windows. (Closed)
Patch Set: Change comment. Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/service/service_process_control.cc
diff --git a/chrome/browser/service/service_process_control.cc b/chrome/browser/service/service_process_control.cc
index acccbda682fa21742223ba926fb919730e049fcd..97975efdfaf5fe96676f31d5855966fe652fc540 100644
--- a/chrome/browser/service/service_process_control.cc
+++ b/chrome/browser/service/service_process_control.cc
@@ -135,6 +135,14 @@ void ServiceProcessControl::Launch(Task* task) {
return;
}
+ // Prevent quick calls to Launch in succession from causing a crash.
+ // TODO(scottbyer) - ServiceProcessControl launch task callback code needs to
+ // be enhanced to deal with this properly. See
+ // http://code.google.com/p/chromium/issues/detail?id=58802
+ if (launcher_) {
+ return;
+ }
+
// A service process should have a different mechanism for starting, but now
// we start it as if it is a child process.
FilePath exe_path = ChildProcessHost::GetChildPath(true);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698