Cancel unused timeout events. Without this change they can...

Cancel unused timeout events.  Without this change they can
accumulate for a while, wasting memory and causing unneeded wakeups.
BUG=25641
TEST=green valgrind or heapchecker on net_unittests

[dank, 2009-11-05 19:15:11]

Hi Timur+glider, please check that this solves the
leak for you.  (I don't think the leak was unbounded,
but it was ugly.)

Jeremy, could you review the libevent-fu?

Thanks...

[jeremy, 2009-11-05 22:51:36]

LGTM

http://codereview.chromium.org/370005/diff/1/2
File base/message_pump_libevent.cc (right):

http://codereview.chromium.org/370005/diff/1/2#newcode218
Line 218: // Tell libevent to break out of inner loop.
nit: expand the comment to point at the bug.

[not_the_right_glider, 2009-11-06 10:28:04]

This patch fixes memory leaks in event_ base_loopexit() seen on my local
heapcheck buildbot. They're not reported when I run Chrome with HEAPCHECK=strict
either.

LGTM (consider fixing lint warnings, please)
On 2009/11/05 19:15:11, dank wrote:
> Hi Timur+glider, please check that this solves the
> leak for you.  (I don't think the leak was unbounded,
> but it was ugly.)
> 
> Jeremy, could you review the libevent-fu?
> 
> Thanks...

[dank, 2009-11-06 21:55:56]

thanks, committed (review 372033 )

[stuartmorgan, 2016-02-09 16:11:44]

Description was changed from

==========
Cancel unused timeout events.  Without this change they can
accumulate for a while, wasting memory and causing unneeded wakeups.
BUG=25641
TEST=green valgrind or heapchecker on net_unittests
==========

to

==========
Cancel unused timeout events.  Without this change they can
accumulate for a while, wasting memory and causing unneeded wakeups.
BUG=25641
TEST=green valgrind or heapchecker on net_unittests
==========