Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: base/thread_collision_warner_unittest.cc

Issue 369001: Improve the run time of base_unittests by about 20s by reducing timeouts in (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/observer_list_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/thread_collision_warner_unittest.cc
diff --git a/base/thread_collision_warner_unittest.cc b/base/thread_collision_warner_unittest.cc
index 238927af83301a280d75f9cb09f6452cb37332eb..b70cfbe2040661b530d3c3725631141cd91bbc8e 100644
--- a/base/thread_collision_warner_unittest.cc
+++ b/base/thread_collision_warner_unittest.cc
@@ -238,7 +238,7 @@ TEST(ThreadCollisionTest, MTScopedBookCriticalSectionTest) {
}
TEST(ThreadCollisionTest, MTSynchedScopedBookCriticalSectionTest) {
- // Queue with a 5 seconds push execution time, hopefuly the two used threads
+ // Queue with a 2 seconds push execution time, hopefuly the two used threads
// in the test will enter the push at same time.
class NonThreadSafeQueue {
public:
@@ -248,7 +248,7 @@ TEST(ThreadCollisionTest, MTSynchedScopedBookCriticalSectionTest) {
void push(int value) {
DFAKE_SCOPED_LOCK(push_pop_);
- PlatformThread::Sleep(5000);
+ PlatformThread::Sleep(2000);
}
int pop() {
@@ -307,7 +307,7 @@ TEST(ThreadCollisionTest, MTSynchedScopedBookCriticalSectionTest) {
}
TEST(ThreadCollisionTest, MTSynchedScopedRecursiveBookCriticalSectionTest) {
- // Queue with a 5 seconds push execution time, hopefuly the two used threads
+ // Queue with a 2 seconds push execution time, hopefuly the two used threads
// in the test will enter the push at same time.
class NonThreadSafeQueue {
public:
@@ -318,7 +318,7 @@ TEST(ThreadCollisionTest, MTSynchedScopedRecursiveBookCriticalSectionTest) {
void push(int) {
DFAKE_SCOPED_RECURSIVE_LOCK(push_pop_);
bar();
- PlatformThread::Sleep(5000);
+ PlatformThread::Sleep(2000);
}
int pop() {
« no previous file with comments | « base/observer_list_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698