Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 3684004: Use 'GtkWidget' instead of '*' for default style rule. (Closed)

Created:
10 years, 2 months ago by xiyuan
Modified:
9 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Use 'GtkWidget' instead of '*' for default style rule. It seems that wildcard '*' has higher precedenace than the base class in style matching. Use 'GtkWidget' is better and we no longer have to explicitly specify rules for dervied classes. BUG=chromium-os:7479 TEST=Verify omnibox edit's selection color is still right. Change-Id: I320efcdcc8066883e859d29a164962bef6754363 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2a9633a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M resources/gtkrc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
xiyuan
10 years, 2 months ago (2010-10-11 18:02:21 UTC) #1
Daniel Erat
10 years, 2 months ago (2010-10-11 19:04:35 UTC) #2
Nice work!  LGTM.

Powered by Google App Engine
This is Rietveld 408576698