fix bookmarks API crash when handling invalid URL

chrome/test/data/extensions/api_test/bookmarks/test.js

 // bookmarks api test
 // browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks
 
 // This is global state that is maintained across tests as a reference
 // to compare against what's fetched from the browser (using compareTrees).
 // TODO(erikkay) It would be better if each test was self-contained and
 // didn't depend on global state.
 var expected = [
   {"children": [
       {children:[], id:"1", parentId:"0", index:0, title:"Bookmarks bar"},
@@ skipping 204 matching lines @@
     }));
     // Insert node3 at index 1 rather than at the end.  This should result in
     // an order of node1, node3, node2.
     chrome.bookmarks.move(node3.id, {parentId:folder.id, index:1},
                           pass(function(results) {
       chrome.test.assertEq(results.parentId, folder.id);
       chrome.test.assertEq(results.index, 1);
       node3.parentId = results.parentId;
       node3.index = 1;
       node2.index = 2;
-      
+
       // update expected to match
       expected[0].children[0].children.pop();
       expected[0].children[0].children.pop();
       expected[0].children[0].children.pop();
       folder.children.push(node1);
       folder.children.push(node3);
       folder.children.push(node2);
 
       verifyTreeIsExpected(pass());
     }));
@@ skipping 40 matching lines @@
 
   function update() {
     var title = "hello world";
     chrome.test.listenOnce(chrome.bookmarks.onChanged, function(id, changes) {
       chrome.test.assertEq(title, changes.title);
     });
     chrome.bookmarks.update(node1.id, {"title": title}, pass(function(results) {
       chrome.test.assertEq(title, results.title);
     }));
 
-    var url = "http://example.com/hello"
+    var url = "http://example.com/hello";
     chrome.bookmarks.update(node1.id, {"url": url}, pass(function(results) {
       // Make sure that leaving out the title does not set the title to empty.
       chrome.test.assertEq(title, results.title);
       chrome.test.assertEq(url, results.url);
+
+      // Empty or invalid URLs should not change the URL.
+      var bad_url = "";
+      chrome.bookmarks.update(node1.id, {"url": bad_url},
+        pass(function(results) {
+          chrome.bookmarks.get(node1.id, pass(function(results) {
+            chrome.test.assertEq(url, results[0].url);
+            chrome.test.log("URL UNCHANGED");
+          }));
+        })
+      );
+
+      // Invalid URLs also generate an error.
+      bad_url = "I am not an URL";
+      chrome.bookmarks.update(node1.id, {"url": bad_url}, fail("Invalid URL.",
+        function(results) {
+          chrome.bookmarks.get(node1.id, pass(function(results) {
+            chrome.test.assertEq(url, results[0].url);
+            chrome.test.log("URL UNCHANGED");
+          }));
+        })
+      );
     }));
   },
 
   function remove() {
     var parentId = node1.parentId;
     chrome.test.listenOnce(chrome.bookmarks.onRemoved,
                            function(id, removeInfo) {
       chrome.test.assertEq(id, node1.id);
       chrome.test.assertEq(removeInfo.parentId, parentId);
       chrome.test.assertEq(removeInfo.index, node1.index);
@@ skipping 125 matching lines @@
                            "Should only get the last 2 bookmarks");
 
       chrome.test.assertTrue(compareNode(node3, results[0]));
       chrome.test.assertTrue(compareNode(node2, results[1]));
     }));
   }
 ]);
 }
 
 run();