Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 367003: Enable localization of default downloaded filename. (Closed)

Created:
11 years, 1 month ago by tony
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enable localization of default downloaded filename. Instead of localizing "download" string in net_util.cc, make a caller, download_manger, provide a localized string. BUG=25289 TEST=NetUtilTest.GetSuggestedFilename,DownloadManagerTest.TestDownloadFilename Original patch by hayato@google.com at: http://codereview.chromium.org/343014/show Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -80 lines) Patch
M app/os_exchange_data_provider_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/web_drag_source.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 1 chunk +10 lines, -1 line 0 comments Download
M chrome/browser/download/save_package.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/base/net_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +32 lines, -27 lines 0 comments Download
M net/base/net_util_unittest.cc View 4 chunks +47 lines, -29 lines 0 comments Download
M webkit/glue/weburlloader_impl.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698