Issue 3667005: Update RemoteUpload to return a set Update if failed_uploads to check deeper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3667005: Update RemoteUpload to return a set Update if failed_uploads to check deeper (Closed)

Created:
10 years, 2 months ago by scottz

Modified:
9 years, 7 months ago

Reviewers:
scottz-goog, anush, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils

Visibility:
Public.

Description

Update RemoteUpload to return a set Update if failed_uploads to check deeper in the returned set to see if it is a bonified failure BUG=NA TEST=Local run to verify Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=96619e7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change list comprehension to use the proper variable #

Patch Set 3 : Add parans around second part of if statement #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	prebuilt.py	View	1 2	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM + nit/? http://codereview.chromium.org/3667005/diff/1/2 File prebuilt.py (right): http://codereview.chromium.org/3667005/diff/1/2#newcode286 prebuilt.py:286: if len(failed_uploads) > 1 or None ...

10 years, 2 months ago (2010-10-11 22:19:15 UTC) #2

scottz-goog

http://codereview.chromium.org/3667005/diff/1/2 File prebuilt.py (right): http://codereview.chromium.org/3667005/diff/1/2#newcode286 prebuilt.py:286: if len(failed_uploads) > 1 or None not in failed_uploads: ...

10 years, 2 months ago (2010-10-11 22:31:29 UTC) #3

sosa

10 years, 2 months ago (2010-10-11 22:35:04 UTC) #4

LGTM

On Mon, Oct 11, 2010 at 3:31 PM,  <scottz@google.com> wrote:
>
> http://codereview.chromium.org/3667005/diff/1/2
> File prebuilt.py (right):
>
> http://codereview.chromium.org/3667005/diff/1/2#newcode286
> prebuilt.py:286: if len(failed_uploads) > 1 or None not in
> failed_uploads:
> On 2010/10/11 22:19:15, sosa wrote:
>>
>> Shouldn't the last or here be a (None not in failed_uploads and
>
> failed_uploads)
>
> Done.
>
> http://codereview.chromium.org/3667005/show
>

Expand Messages | Collapse Messages