 Chromium Code Reviews
 Chromium Code Reviews Issue 3666001:
  Defer the prefix/postfix code generation.  (Closed) 
  Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
    
  
    Issue 3666001:
  Defer the prefix/postfix code generation.  (Closed) 
  Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/| Index: src/arm/virtual-frame-arm.h | 
| =================================================================== | 
| --- src/arm/virtual-frame-arm.h (revision 5606) | 
| +++ src/arm/virtual-frame-arm.h (working copy) | 
| @@ -391,6 +391,16 @@ | 
| static Register scratch0() { return r7; } | 
| static Register scratch1() { return r9; } | 
| + inline void RaiseHeight(int count, unsigned known_smi_map = 0) { | 
| + ASSERT(count >= 32 || known_smi_map < (1u << count)); | 
| + element_count_ += count; | 
| + if (count >= kTOSKnownSmiMapSize) { | 
| + tos_known_smi_map_ = known_smi_map; | 
| + } else { | 
| + tos_known_smi_map_ = ((tos_known_smi_map_ << count) | known_smi_map); | 
| + } | 
| + } | 
| 
Erik Corry
2010/11/05 22:04:36
This change is not necessary if EmitPush is used.
 
zhangk
2010/11/09 23:07:53
On 2010/11/05 22:04:36, Erik Corry wrote:
Done.
 | 
| + | 
| private: | 
| static const int kLocal0Offset = JavaScriptFrameConstants::kLocal0Offset; | 
| static const int kFunctionOffset = JavaScriptFrameConstants::kFunctionOffset; | 
| @@ -500,16 +510,6 @@ | 
| } | 
| } | 
| - inline void RaiseHeight(int count, unsigned known_smi_map = 0) { | 
| - ASSERT(count >= 32 || known_smi_map < (1u << count)); | 
| - element_count_ += count; | 
| - if (count >= kTOSKnownSmiMapSize) { | 
| - tos_known_smi_map_ = known_smi_map; | 
| - } else { | 
| - tos_known_smi_map_ = ((tos_known_smi_map_ << count) | known_smi_map); | 
| - } | 
| - } | 
| - | 
| friend class JumpTarget; | 
| }; |