Issue 366027: Fix case where we treat an unaliased call to eval as an aliased call...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 366027: Fix case where we treat an unaliased call to eval as an aliased call... (Closed)

Created:
11 years, 1 month ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix case where we treat an unaliased call to eval as an aliased call to eval. BUG=http://code.google.com/p/v8/issues/detail?id=496 Committed: http://code.google.com/p/v8/source/detail?r=3225

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -2 lines)			Patch
	M	src/scopes.cc	View		1 chunk	+4 lines, -2 lines	1 comment	Download
	A	test/mjsunit/regress/regress-496.js	View		1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 1 month ago (2009-11-05 11:12:47 UTC) #2

LGTM.

http://codereview.chromium.org/366027/diff/1/3
File src/scopes.cc (right):

http://codereview.chromium.org/366027/diff/1/3#newcode543
Line 543: // the statically resolved (local!) variable belonging to an outer
scope,
Could you delete "(local!)" from this comment?

Expand Messages | Collapse Messages