Issue 366015: Fix theme install crasher....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 366015: Fix theme install crasher.... (Closed)

Created:
11 years, 1 month ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix theme install crasher. BUG=26704 TEST= change themes. browser does not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31036

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/extensions/theme_installed_infobar_delegate.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM. Maybe on Linux we don't create the invisible ok button?

11 years, 1 month ago (2009-11-04 22:30:39 UTC) #2

Miranda Callahan

11 years, 1 month ago (2009-11-04 22:40:04 UTC) #3

On 2009/11/04 22:30:39, tony wrote:
> LGTM.  Maybe on Linux we don't create the invisible ok button?

Perhaps -- it's code in the Views::Layout that wants to do things with the
button and crashes it.  The ConfirmInfoBar layout seems to go back and forth
between assuming there is always an ok_button, and checking to see whether it
exists or not.  I tried to impose strict checking hygiene here, but it was
insufficient -- the assumed OK button is in pretty deep.  But for now, just
allowing the invisible button does no real harm, and takes us back to where we
were before the regression.

Expand Messages | Collapse Messages