Issue 366004: Add support for debugger statement to top-level compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 366004: Add support for debugger statement to top-level compiler. (Closed)

Created:
11 years, 1 month ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add support for debugger statement to top-level compiler. Committed: http://code.google.com/p/v8/source/detail?r=3220

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	src/compiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/fast-codegen.cc	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/366004/diff/1/3 File src/fast-codegen.cc (right): http://codereview.chromium.org/366004/diff/1/3#newcode406 Line 406: #ifdef ENABLE_DEBUGGER_SUPPORT I think the entire body ...

11 years, 1 month ago (2009-11-04 18:36:08 UTC) #2

fschneider

11 years, 1 month ago (2009-11-04 18:52:11 UTC) #3

http://codereview.chromium.org/366004/diff/1/3
File src/fast-codegen.cc (right):

http://codereview.chromium.org/366004/diff/1/3#newcode406
Line 406: #ifdef ENABLE_DEBUGGER_SUPPORT
On 2009/11/04 18:36:08, Kevin Millikin wrote:
> I think the entire body should be wrapped in the #ifdef.  If debugger support
is
> disabled, then we don't really need the comment or to set the statement
> position.

Done.

Expand Messages | Collapse Messages

Issue 366004: Add support for debugger statement to top-level compiler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages