Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 3660002: Rename ChromeThread to BrowserThread Part13: (Closed)

Created:
10 years, 2 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews, michaeln, ben+cc_chromium.org, Sergey Ulanov, Erik does not do reviews, Alpha Left Google, Aaron Boodman, dmac, pam+watch_chromium.org, awong, garykac, Paweł Hajdan Jr., brettw-cc_chromium.org, davemoore+watch_chromium.org
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

Rename ChromeThread to BrowserThread Part13: - Rename entries under appcache, automation, chromeos, cocoa, file_system, metrics, policy, prefs, remoting, search_engines and tab_contents. BUG=56926 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62120

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -90 lines) Patch
M chrome/browser/appcache/chrome_appcache_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/ui_controls_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/syslogs_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/dom_ui/menu_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/browser_test_helper.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/cocoa/bug_report_window_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/collected_cookies_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/extension_installed_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/notifications/balloon_controller_unittest.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/ssl_client_certificate_selector.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/tabpose_window.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/file_system/file_system_dispatcher_host.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/file_system/file_system_host_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/histogram_synchronizer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_provider.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_provider_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/pref_notifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_value_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_value_store.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/prefs/pref_value_store_unittest.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/remoting/remoting_setup_flow.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_source_win.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
10 years, 2 months ago (2010-10-10 15:19:34 UTC) #1
willchan no longer on Chromium
10 years, 2 months ago (2010-10-10 18:46:30 UTC) #2
LGTM!

On Sun, Oct 10, 2010 at 8:19 AM, <tfarina@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Rename ChromeThread to BrowserThread Part13:
>
> - Rename entries under appcache, automation, chromeos, cocoa,
> file_system, metrics, policy, prefs, remoting, search_engines
> and tab_contents.
>
> BUG=56926
> TEST=trybots
>
> Please review this at http://codereview.chromium.org/3660002/show
>
> SVN Base: git://git.chromium.org/chromium.git
>
> Affected files:
>  M chrome/browser/appcache/chrome_appcache_service.h
>  M chrome/browser/automation/ui_controls_mac.mm
>  M chrome/browser/chromeos/cros/syslogs_library.cc
>  M chrome/browser/chromeos/dom_ui/menu_ui.cc
>  M chrome/browser/cocoa/browser_test_helper.h
>  M chrome/browser/cocoa/bug_report_window_controller_unittest.mm
>  M chrome/browser/cocoa/collected_cookies_mac_unittest.mm
>  M chrome/browser/cocoa/extension_installed_bubble_controller.mm
>  M chrome/browser/cocoa/notifications/balloon_controller_unittest.mm
>  M chrome/browser/cocoa/ssl_client_certificate_selector.mm
>  M chrome/browser/cocoa/tabpose_window.mm
>  M chrome/browser/file_system/file_system_dispatcher_host.cc
>  M chrome/browser/file_system/file_system_host_context_unittest.cc
>  M chrome/browser/metrics/histogram_synchronizer.cc
>  M chrome/browser/policy/config_dir_policy_provider.cc
>  M chrome/browser/policy/config_dir_policy_provider_unittest.cc
>  M chrome/browser/prefs/pref_notifier.cc
>  M chrome/browser/prefs/pref_service.cc
>  M chrome/browser/prefs/pref_value_store.h
>  M chrome/browser/prefs/pref_value_store.cc
>  M chrome/browser/prefs/pref_value_store_unittest.cc
>  M chrome/browser/remoting/remoting_setup_flow.cc
>  M chrome/browser/search_engines/search_provider_install_data.cc
>  M chrome/browser/tab_contents/interstitial_page.cc
>  M chrome/browser/tab_contents/render_view_host_manager_unittest.cc
>  M chrome/browser/tab_contents/web_contents_unittest.cc
>  M chrome/browser/tab_contents/web_drag_source_win.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698