Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 3659002: Add ability to download using newest image from zip url. (Closed)

Created:
10 years, 2 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
scottz-goog, scottz
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add ability to download using newest image from zip url. This changes the behavior of ctest to try to grab the latest zip from the zip web pages if it can't use the latest link (due to IOError or none provided). It assumes they have an Apache server and they reference images using version->ChromeOS-version-.*.zip) for each board/channel. Change-Id: I4ee075db7afd58c8d08f59aca2e69b5bab5ff5e9 BUG=7675 TEST=Ran it with -l "http://Doesnotexist" and also without a -l option. Added new unittests to test and ran them as well. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=af62e73

Patch Set 1 #

Patch Set 2 : Add unittests #

Total comments: 6

Patch Set 3 : clean up docstrings #

Patch Set 4 : Make regex better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -17 lines) Patch
M bin/ctest.py View 1 2 3 4 chunks +84 lines, -16 lines 0 comments Download
M bin/ctest_unittest.py View 1 2 3 4 chunks +64 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sosa
10 years, 2 months ago (2010-10-12 21:09:39 UTC) #1
scottz
http://codereview.chromium.org/3659002/diff/2001/3001 File bin/ctest.py (right): http://codereview.chromium.org/3659002/diff/2001/3001#newcode29 bin/ctest.py:29: 'ChromeOS-\d+\.\d+\.\d+\.\d+-.*\.zip' Is there something you wanted to do with ...
10 years, 2 months ago (2010-10-12 21:18:15 UTC) #2
sosa
Thanks for the quick review, PTAL http://codereview.chromium.org/3659002/diff/2001/3001 File bin/ctest.py (right): http://codereview.chromium.org/3659002/diff/2001/3001#newcode29 bin/ctest.py:29: 'ChromeOS-\d+\.\d+\.\d+\.\d+-.*\.zip' On 2010/10/12 ...
10 years, 2 months ago (2010-10-12 21:38:25 UTC) #3
scottz-goog
10 years, 2 months ago (2010-10-12 22:06:06 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698