Issue 365004: When updating on a user ticket, check for system tickets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 365004: When updating on a user ticket, check for system tickets (Closed)

Created:
11 years, 1 month ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Mark Dalrymple, TVL

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

When updating on a user ticket, check for system tickets. If a system ticket is also present, delete the user ticket and abort the update. BUG=26702 TEST=keystone_install_test.sh Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30975

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -26 lines)			Patch
	M	chrome/tools/build/mac/keystone_install.sh	View	1 2	12 chunks	+49 lines, -26 lines	0 comments	Download
	M	chrome/tools/build/mac/keystone_install_test.sh	View		3 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

I reordered the exit codes to be sequential. Nothing actually cared about the specific codes, ...

11 years, 1 month ago (2009-11-04 18:13:16 UTC) #1

Mark Dalrymple

LGTM. OBTW, the next version of keystone (after this chromestuff™ one) I plan on sending ...

11 years, 1 month ago (2009-11-04 18:23:23 UTC) #2

Mark Mentovai

http://codereview.chromium.org/365004/diff/1001/1003 File chrome/tools/build/mac/keystone_install.sh (right): http://codereview.chromium.org/365004/diff/1001/1003#newcode177 Line 177: ksadmin --delete -P "${PRODUCT_ID}" I'll add || true

11 years, 1 month ago (2009-11-04 18:25:17 UTC) #3

TVL

11 years, 1 month ago (2009-11-04 18:28:25 UTC) #4

lg with question

http://codereview.chromium.org/365004/diff/1001/1003
File chrome/tools/build/mac/keystone_install.sh (right):

http://codereview.chromium.org/365004/diff/1001/1003#newcode177
Line 177: ksadmin --delete -P "${PRODUCT_ID}"
can this fail and give you a different exit code on the script?

Expand Messages | Collapse Messages