Issue 3647002: monitor_reconfig: Add script to run for external displays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3647002: monitor_reconfig: Add script to run for external displays. (Closed)

Created:
10 years, 2 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/monitor_reconfig.git

Visibility:
Public.

Description

monitor_reconfig: Add script to run for external displays. This adds a run_monitor_configure script that uses xrandr to check if there's an external display connected, and then runs monitor_reconfigure if so. I plan to make us run this after starting the X server. Change-Id: Ia19b5832950e405d9d88295226771d6364846b99 BUG=chromium-os:1743 TEST=ran it Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=afaeace

Patch Set 1 #

Total comments: 1

Patch Set 2 : update path #

Patch Set 3 : apply review feedback #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	A	run_monitor_reconfigure	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM w/ nit http://codereview.chromium.org/3647002/diff/1/2 File run_monitor_reconfigure (right): http://codereview.chromium.org/3647002/diff/1/2#newcode18 run_monitor_reconfigure:18: if (( test "$NUM_OUTPUTS" -gt 1 ...

10 years, 2 months ago (2010-10-09 00:37:50 UTC) #2

Daniel Erat

10 years, 2 months ago (2010-10-09 00:44:04 UTC) #3

On 2010/10/09 00:37:50, sosa wrote:
> LGTM w/ nit
> 
> http://codereview.chromium.org/3647002/diff/1/2
> File run_monitor_reconfigure (right):
> 
> http://codereview.chromium.org/3647002/diff/1/2#newcode18
> run_monitor_reconfigure:18: if (( test "$NUM_OUTPUTS" -gt 1 )); then
> Why not just use  [ ] rather than an explicit call to test?

Because I hate shell scripting and can never keep track of what [[, ((, and [ do
and which ones are supported by bash/dash/sh. :-(  Thanks, updated.

Expand Messages | Collapse Messages