Issue 3646005: Gets image_to_live to work with a custom devserver_port

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3646005: Gets image_to_live to work with a custom devserver_port (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Gets image_to_live to work with a custom devserver_port BUG= TEST=Ran image_to_live using port 9090 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4bec3be

Patch Set 1 #

Patch Set 2 : last #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	image_to_live.sh	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 2 months ago (2010-10-12 00:43:35 UTC) #2

LGTM after fixing the order of the redirect and the final --port option.

On Mon, Oct 11, 2010 at 5:11 PM, <sosa@chromium.org> wrote:

> Reviewers: kmixter1,
>
> Message:
> The old devserver_port code didn't really do anything.
>
> Description:
> Gets image_to_live to work with a custom devserver_port
>
> BUG=
> TEST=Ran image_to_live using port 9090
>
> Please review this at http://codereview.chromium.org/3646005/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git
>
> Affected files:
>  M image_to_live.sh
>
>
> Index: image_to_live.sh
> diff --git a/image_to_live.sh b/image_to_live.sh
> index
>
76942912f29384af5bed4c2026285160095b9c5e..99b1381b14760cfc5a5d661f008f40d9606e39f0
> 100755
> --- a/image_to_live.sh
> +++ b/image_to_live.sh
> @@ -89,7 +89,7 @@ function reinterpret_path_for_chroot() {
>
>  function start_dev_server {
>   kill_all_devservers
> -  local devserver_flags=${FLAGS_devserver_port}
> +  local devserver_flags=
>   # Parse devserver flags.
>   if [ -n "${FLAGS_image}" ]; then
>     devserver_flags="${devserver_flags} \
> @@ -111,7 +111,8 @@ function start_dev_server {
>
>   info "Starting devserver with flags ${devserver_flags}"
>   ./enter_chroot.sh "sudo ./start_devserver ${devserver_flags} \
> -       --client_prefix=ChromeOSUpdateEngine > ${FLAGS_server_log} 2>&1" &
> +       --client_prefix=ChromeOSUpdateEngine > ${FLAGS_server_log} \
> +       --port=${FLAGS_devserver_port} 2>&1" &
>
>   echo -n "Waiting on devserver to start"
>   until netstat -anp 2>&1 | grep 0.0.0.0:${FLAGS_devserver_port} >
> /dev/null
>
>
>

Expand Messages | Collapse Messages