Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 3646004: Add an option ProxyService::Create() to disable use of proxy auto-config.... (Closed)

Created:
10 years, 2 months ago by eroman
Modified:
9 years, 6 months ago
Reviewers:
Marshall
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, amit, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

Add an option ProxyService::Create() to disable use of proxy auto-config. BUG=40797 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62487

Patch Set 1 #

Total comments: 1

Patch Set 2 : change to use separate functions #

Patch Set 3 : fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -52 lines) Patch
M chrome/browser/net/chrome_url_request_context.cc View 1 1 chunk +11 lines, -5 lines 0 comments Download
M chrome/browser/net/connection_tester.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/service/net/service_url_request_context.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome_frame/metrics_service.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M net/proxy/proxy_service.h View 1 2 chunks +17 lines, -9 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 2 3 chunks +60 lines, -25 lines 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eroman
http://codereview.chromium.org/3646004/diff/1/9 File webkit/tools/test_shell/test_shell_request_context.cc (right): http://codereview.chromium.org/3646004/diff/1/9#newcode67 webkit/tools/test_shell/test_shell_request_context.cc:67: net::ProxyService::PROXY_RESOLVER_SYSTEM, 0, NULL, NULL, NULL); After this change, you ...
10 years, 2 months ago (2010-10-11 20:09:28 UTC) #1
eroman
Modified the CL to use separate function names instead of the enum.
10 years, 2 months ago (2010-10-11 23:35:16 UTC) #2
Marshall
On Windows 7 the "Automatically detect settings" checkbox under "LAN settings" defaults to checked. Does ...
10 years, 2 months ago (2010-10-12 13:51:34 UTC) #3
eroman
I think we should keep things simple and either support proxy-autoconfig, or not support it. ...
10 years, 2 months ago (2010-10-13 01:13:24 UTC) #4
Marshall
10 years, 2 months ago (2010-10-13 13:24:15 UTC) #5
OK, LGTM

Powered by Google App Engine
This is Rietveld 408576698