Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Issue 3635001: crosutils: Detect sym_upload errors by its stdout instead of return value (Closed)

Created:
10 years, 2 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

crosutils: Detect sym_upload errors by its stdout instead of return value Change-Id: If649d355f3d9cb2650613e4eb6d34813216c0b61 BUG=7516 TEST=Change hardcoded URL to illegal URL and verify symbol sends fail Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f5adf79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M upload_symbols View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kmixter1
10 years, 2 months ago (2010-10-08 00:48:12 UTC) #1
petkov
10 years, 2 months ago (2010-10-08 00:50:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698