Issue 3631001: #include <ostream> in base/string16.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3631001: #include <ostream> in base/string16.cc (Closed)

Created:
10 years, 2 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

#include <ostream> in base/string16.cc. This is required for the Mac OS X 10.6 SDK build. Otherwise, various bits of <ostream> that would be needed are declared but not defined. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61813

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	base/string16.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

10 years, 2 months ago (2010-10-07 18:10:21 UTC) #3

Looks like rietveld agrees.

On Thu, Oct 7, 2010 at 11:09 AM,  <thakis@chromium.org> wrote:
> looks AMAZING, please check-in immediately!
>
> http://codereview.chromium.org/3631001/show
>

Expand Messages | Collapse Messages