net/socket/socks_client_socket_unittest.cc - Issue 363025: Improve the display of LoadLogs when truncation occurs....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket_unittest.cc

Issue 363025: Improve the display of LoadLogs when truncation occurs.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Change -1 to be a constant instead Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/socks_client_socket_unittest.cc

===================================================================

--- net/socket/socks_client_socket_unittest.cc (revision 31195)

+++ net/socket/socks_client_socket_unittest.cc (working copy)

@@ -93,7 +93,7 @@

EXPECT_TRUE(tcp_sock_->IsConnected());

EXPECT_FALSE(user_sock_->IsConnected());

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

int rv = user_sock_->Connect(&callback_, log);

EXPECT_EQ(ERR_IO_PENDING, rv);

EXPECT_TRUE(

@@ -154,7 +154,7 @@

MockRead(false, tests[i].fail_reply, arraysize(tests[i].fail_reply)) };

user_sock_.reset(BuildMockSocket(data_reads, data_writes, "localhost", 80));

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

int rv = user_sock_->Connect(&callback_, log);

EXPECT_EQ(ERR_IO_PENDING, rv);

@@ -182,7 +182,7 @@

MockRead(true, kSOCKSPartialReply2, arraysize(kSOCKSPartialReply2)) };

user_sock_.reset(BuildMockSocket(data_reads, data_writes, "localhost", 80));

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

int rv = user_sock_->Connect(&callback_, log);

EXPECT_EQ(ERR_IO_PENDING, rv);

@@ -212,7 +212,7 @@

MockRead(true, kSOCKSOkReply, arraysize(kSOCKSOkReply)) };

user_sock_.reset(BuildMockSocket(data_reads, data_writes, "localhost", 80));

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

int rv = user_sock_->Connect(&callback_, log);

EXPECT_EQ(ERR_IO_PENDING, rv);

@@ -236,7 +236,7 @@

MockRead(false, 0) };

user_sock_.reset(BuildMockSocket(data_reads, data_writes, "localhost", 80));

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

int rv = user_sock_->Connect(&callback_, log);

EXPECT_EQ(ERR_IO_PENDING, rv);

@@ -265,7 +265,7 @@

MockRead(false, kSOCKSOkReply, arraysize(kSOCKSOkReply)) };

user_sock_.reset(BuildMockSocket(data_reads, data_writes, hostname, 80));

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

int rv = user_sock_->Connect(&callback_, log);

EXPECT_EQ(ERR_IO_PENDING, rv);

@@ -296,7 +296,7 @@

MockRead(false, kSOCKSOkReply, arraysize(kSOCKSOkReply)) };

user_sock_.reset(BuildMockSocket(data_reads, data_writes, hostname, 80));

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

int rv = user_sock_->Connect(&callback_, log);

EXPECT_EQ(ERR_IO_PENDING, rv);

« no previous file with comments | « net/socket/socks5_client_socket_unittest.cc ('k') | net/socket/ssl_client_socket_unittest.cc » ('j') | no next file with comments »