net/proxy/init_proxy_resolver_unittest.cc - Issue 363025: Improve the display of LoadLogs when truncation occurs....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/init_proxy_resolver_unittest.cc

Issue 363025: Improve the display of LoadLogs when truncation occurs.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Change -1 to be a constant instead Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/init_proxy_resolver_unittest.cc

===================================================================

--- net/proxy/init_proxy_resolver_unittest.cc (revision 31195)

+++ net/proxy/init_proxy_resolver_unittest.cc (working copy)

@@ -171,7 +171,7 @@

Rules::Rule rule = rules.AddSuccessRule("http://custom/proxy.pac");

TestCompletionCallback callback;

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

InitProxyResolver init(&resolver, &fetcher);

EXPECT_EQ(OK, init.Init(config, &callback, log));

EXPECT_EQ(rule.bytes(), resolver.pac_bytes());

@@ -204,7 +204,7 @@

rules.AddFailDownloadRule("http://custom/proxy.pac");

TestCompletionCallback callback;

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

InitProxyResolver init(&resolver, &fetcher);

EXPECT_EQ(kFailedDownloading, init.Init(config, &callback, log));

EXPECT_EQ("", resolver.pac_bytes());

@@ -288,7 +288,7 @@

Rules::Rule rule = rules.AddSuccessRule("http://custom/proxy.pac");

TestCompletionCallback callback;

- scoped_refptr<LoadLog> log(new LoadLog);

+ scoped_refptr<LoadLog> log(new LoadLog(LoadLog::kUnbounded));

InitProxyResolver init(&resolver, &fetcher);

EXPECT_EQ(OK, init.Init(config, &callback, log));

EXPECT_EQ(rule.bytes(), resolver.pac_bytes());

« no previous file with comments | « net/http/http_cache_unittest.cc ('k') | net/proxy/proxy_resolver_v8_unittest.cc » ('j') | no next file with comments »