Implement cancel() API on a Notification object so that script can cancel or ...

Implement cancel() API on a Notification object so that script can cancel or tear down a toast.

BUG=26360
TEST=cancel a notification


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31004

[michaeln, 2009-11-04 20:16:00]

http://codereview.chromium.org/363003/diff/4001/5013
File chrome/browser/notifications/notification.h (right):

http://codereview.chromium.org/363003/diff/4001/5013#newcode40
Line 40: bool IsSameNotificationObject(const Notification& other) const {
maybe just IsSameNotification(other)

http://codereview.chromium.org/363003/diff/4001/5010
File chrome/browser/notifications/notification_object_proxy.h (right):

http://codereview.chromium.org/363003/diff/4001/5010#newcode38
Line 38: bool equals(const NotificationObjectProxy& other) const {
Maybe rename this to IsSame(...) to harmonize with IsSameNotificationObject.

http://codereview.chromium.org/363003/diff/4001/5010#newcode60
Line 60: const NotificationObjectProxy& b) {
Can you avoid the operator overload? I see that its used in
IsSameNotificationObject method, is that the only callsite?

[John Gregg, 2009-11-04 20:40:29]

New code posted.

http://codereview.chromium.org/363003/diff/4001/5013
File chrome/browser/notifications/notification.h (right):

http://codereview.chromium.org/363003/diff/4001/5013#newcode40
Line 40: bool IsSameNotificationObject(const Notification& other) const {
On 2009/11/04 20:16:00, michaeln wrote:
> maybe just IsSameNotification(other)

made it IsSame(other) after other comment.

http://codereview.chromium.org/363003/diff/4001/5010
File chrome/browser/notifications/notification_object_proxy.h (right):

http://codereview.chromium.org/363003/diff/4001/5010#newcode38
Line 38: bool equals(const NotificationObjectProxy& other) const {
On 2009/11/04 20:16:00, michaeln wrote:
> Maybe rename this to IsSame(...) to harmonize with IsSameNotificationObject.

Done.

http://codereview.chromium.org/363003/diff/4001/5010#newcode60
Line 60: const NotificationObjectProxy& b) {
On 2009/11/04 20:16:00, michaeln wrote:
> Can you avoid the operator overload? I see that its used in
> IsSameNotificationObject method, is that the only callsite?

Is that too clever?  No, I'm not using it for any STL magic, just my own
equality check, so yes I can use the function directly.  I'll change to that.

[michaeln, 2009-11-04 20:56:56]

LGTM