Issue 3628002: Add a simple wrapper script around vm lib to start a vm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3628002: Add a simple wrapper script around vm lib to start a vm. (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Add a simple wrapper script around vm lib to start a vm. Change-Id: Ic3238b3063d0e889c424ff6a9792d9c0f6bebca1 BUG= TEST=Ran it Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d76a917

Patch Set 1 #

Patch Set 2 : Clean up output in vm lib. #

Total comments: 1

Patch Set 3 : Add echo #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -6 lines)			Patch
	A	bin/cros_start_vm	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download
	M	lib/cros_vm_lib.sh	View		3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sosa

Scripts takes --ssh_port (default 9222) Also uses latest qemu image if none specified.

10 years, 2 months ago (2010-10-08 06:03:05 UTC) #2

petkov

LGTM, thanks! Does this print what ssh port it listens to? If not, it would ...

10 years, 2 months ago (2010-10-08 06:04:05 UTC) #3

sosa

PTAL I also cleaned up some stuff going to stdout in the vm_lib so that ...

10 years, 2 months ago (2010-10-08 06:10:13 UTC) #4

petkov

10 years, 2 months ago (2010-10-08 06:13:27 UTC) #5

still LGTM w/ another suggested improvement

http://codereview.chromium.org/3628002/diff/5001/6001
File bin/cros_start_vm (right):

http://codereview.chromium.org/3628002/diff/5001/6001#newcode32
bin/cros_start_vm:32: echo ${FLAGS_ssh_port}
Just like remote gdb, it would be useful to just print the whole ssh command so
that one can mark and paste.

Expand Messages | Collapse Messages