Implement Instant on Mac

[Mac] Initial Instant implementation.

This is a very rough cut.  Many things are still unfinished and will be fixed in future CLs:
- Clicking on instant results clears the results.
- Suggestions do not work yet.
- The omnibox popup overlaps with instant results.
- HTTP auth dialogs cause crashes.

BUG=56385
TEST=No visible impact when --enable-match-preview is not set on the command line.
TEST=Instant results should appear when typing in the omnibox.
TEST=Instant results should disappear when clicking outside the browser window or clicking on devtools or the sidebar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62221

[rohitrao (ping after 24h), 2010-10-11 20:58:56]

If you guys can take a look at this today, that would be great.  It looks like
this needs to be in for M8, albeit behind a flag.

There's not too much in this CL that would cause problems sans flag.  I've
looked through all of the new code in location_bar_view_mac.mm and it all is
gated behind "if (browser_->instant())".

[viettrungluu, 2010-10-11 22:46:03]

The changes to browser_window_*, previewable_contents_controller.mm, and
tab_contents_view_mac.mm look okay to me. I don't know enough about the Omnibox
code to comment without thinking harder.

http://codereview.chromium.org/3624001/diff/78001/79004
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/3624001/diff/78001/79004#newcode1733
chrome/browser/cocoa/browser_window_controller.mm:1733: // instant isn't
showing.
My preference might have been to make -hidePreview safe to call (i.e., do
nothing) when it's already hidden, but whatever.

http://codereview.chromium.org/3624001/diff/78001/79009
File chrome/browser/tab_contents/tab_contents_view_mac.mm (right):

http://codereview.chromium.org/3624001/diff/78001/79009#newcode83
chrome/browser/tab_contents/tab_contents_view_mac.mm:83: [view
setAutoresizingMask:NSViewWidthSizable|NSViewHeightSizable];
Nit: According to the style guide, you're supposed to have spaces around the
'|'.

[rohitrao (ping after 24h), 2010-10-11 22:55:17]

Thanks.

Scott, all you have to look at are autocomplete_edit_view_* and
location_bar_view_*.  These should just be mirrors of the windows code.  At
least, that was the intention.

http://codereview.chromium.org/3624001/diff/78001/79004
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/3624001/diff/78001/79004#newcode1733
chrome/browser/cocoa/browser_window_controller.mm:1733: // instant isn't
showing.
On 2010/10/11 22:46:03, viettrungluu wrote:
> My preference might have been to make -hidePreview safe to call (i.e., do
> nothing) when it's already hidden, but whatever.

I've got a DCHECK in there for now to make sure it isn't called twice.  It's
very likely that I'll make hidePreview safe to call, but I want to play with it
a bit more first.

http://codereview.chromium.org/3624001/diff/78001/79009
File chrome/browser/tab_contents/tab_contents_view_mac.mm (right):

http://codereview.chromium.org/3624001/diff/78001/79009#newcode83
chrome/browser/tab_contents/tab_contents_view_mac.mm:83: [view
setAutoresizingMask:NSViewWidthSizable|NSViewHeightSizable];
On 2010/10/11 22:46:03, viettrungluu wrote:
> Nit: According to the style guide, you're supposed to have spaces around the
> '|'.

Done, but then I felt the need to wrap it all in parens =)

[sky, 2010-10-11 22:55:32]

http://codereview.chromium.org/3624001/diff/78001/79005
File chrome/browser/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/3624001/diff/78001/79005#newcode453
chrome/browser/cocoa/browser_window_controller_private.mm:453: return (contents
&&
Does the style guide for Objective-C say no () around return statements like it
does for C++?

http://codereview.chromium.org/3624001/diff/78001/79007
File chrome/browser/cocoa/location_bar/location_bar_view_mac.mm (right):

http://codereview.chromium.org/3624001/diff/78001/79007#newcode278
chrome/browser/cocoa/location_bar/location_bar_view_mac.mm:278: if
(browser_->instant())
This needs to always happen. Meaning if you early return on 249/256... it won't.

[rohitrao (ping after 24h), 2010-10-11 23:08:21]

http://codereview.chromium.org/3624001/diff/78001/79005
File chrome/browser/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/3624001/diff/78001/79005#newcode453
chrome/browser/cocoa/browser_window_controller_private.mm:453: return (contents
&&
On 2010/10/11 22:55:32, sky wrote:
> Does the style guide for Objective-C say no () around return statements like
it
> does for C++?

Removed.

http://codereview.chromium.org/3624001/diff/78001/79007
File chrome/browser/cocoa/location_bar/location_bar_view_mac.mm (right):

http://codereview.chromium.org/3624001/diff/78001/79007#newcode278
chrome/browser/cocoa/location_bar/location_bar_view_mac.mm:278: if
(browser_->instant())
On 2010/10/11 22:55:32, sky wrote:
> This needs to always happen. Meaning if you early return on 249/256... it
won't.

Whoa, good catch.  There was a huge warning in the windows version and
everything =(

Fixed to match windows.

[viettrungluu, 2010-10-11 23:14:27]

http://codereview.chromium.org/3624001/diff/78001/79005
File chrome/browser/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/3624001/diff/78001/79005#newcode453
chrome/browser/cocoa/browser_window_controller_private.mm:453: return (contents
&&
On 2010/10/11 22:55:32, sky wrote:
> Does the style guide for Objective-C say no () around return statements like
it
> does for C++?

Actually, to quote the public C++ style guide:

Return Values

link ▽ Do not needlessly surround the return expression with parentheses.
Use parentheses in return expr; only where you would use them in x = expr;.

return result;                  // No parentheses in the simple case.
return (some_long_condition &&  // Parentheses ok to make a complex
        another_condition);     //     expression more readable.
return (value);                // You wouldn't write var = (value);
return(result);                // return is not a function!

[sky, 2010-10-11 23:56:23]

LGTM