Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 3624001: Implement Instant on Mac (Closed)

Created:
10 years, 2 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Mac] Initial Instant implementation. This is a very rough cut. Many things are still unfinished and will be fixed in future CLs: - Clicking on instant results clears the results. - Suggestions do not work yet. - The omnibox popup overlaps with instant results. - HTTP auth dialogs cause crashes. BUG=56385 TEST=No visible impact when --enable-match-preview is not set on the command line. TEST=Instant results should appear when typing in the omnibox. TEST=Instant results should disappear when clicking outside the browser window or clicking on devtools or the sidebar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62221

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Total comments: 9

Patch Set 13 : '' #

Patch Set 14 : '' #

Patch Set 15 : '' #

Patch Set 16 : '' #

Patch Set 17 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -34 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 2 3 4 5 6 7 8 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 1 2 3 4 5 6 7 8 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller_private.mm View 1 2 3 4 5 6 7 15 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/cocoa/location_bar/location_bar_view_mac.h View 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/location_bar/location_bar_view_mac.mm View 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +72 lines, -28 lines 0 comments Download
M chrome/browser/cocoa/previewable_contents_controller.mm View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 5 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rohitrao (ping after 24h)
If you guys can take a look at this today, that would be great. It ...
10 years, 2 months ago (2010-10-11 20:58:56 UTC) #1
viettrungluu
The changes to browser_window_*, previewable_contents_controller.mm, and tab_contents_view_mac.mm look okay to me. I don't know enough ...
10 years, 2 months ago (2010-10-11 22:46:03 UTC) #2
rohitrao (ping after 24h)
Thanks. Scott, all you have to look at are autocomplete_edit_view_* and location_bar_view_*. These should just ...
10 years, 2 months ago (2010-10-11 22:55:17 UTC) #3
sky
http://codereview.chromium.org/3624001/diff/78001/79005 File chrome/browser/cocoa/browser_window_controller_private.mm (right): http://codereview.chromium.org/3624001/diff/78001/79005#newcode453 chrome/browser/cocoa/browser_window_controller_private.mm:453: return (contents && Does the style guide for Objective-C ...
10 years, 2 months ago (2010-10-11 22:55:32 UTC) #4
rohitrao (ping after 24h)
http://codereview.chromium.org/3624001/diff/78001/79005 File chrome/browser/cocoa/browser_window_controller_private.mm (right): http://codereview.chromium.org/3624001/diff/78001/79005#newcode453 chrome/browser/cocoa/browser_window_controller_private.mm:453: return (contents && On 2010/10/11 22:55:32, sky wrote: > ...
10 years, 2 months ago (2010-10-11 23:08:21 UTC) #5
viettrungluu
http://codereview.chromium.org/3624001/diff/78001/79005 File chrome/browser/cocoa/browser_window_controller_private.mm (right): http://codereview.chromium.org/3624001/diff/78001/79005#newcode453 chrome/browser/cocoa/browser_window_controller_private.mm:453: return (contents && On 2010/10/11 22:55:32, sky wrote: > ...
10 years, 2 months ago (2010-10-11 23:14:27 UTC) #6
sky
10 years, 2 months ago (2010-10-11 23:56:23 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698