Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 3622003: Added support for boards with only private overlays. (crosutils) (Closed)

Created:
10 years, 2 months ago by Dave Parker
Modified:
9 years, 7 months ago
Reviewers:
davidjames, robotboy, anush
CC:
chromium-os-reviews_chromium.org, micahc, Tammo Spalink, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Added support for boards with only private overlays. (crosutils) If a board has a public overlay it will be used as the primary overlay. However, with this change, if a board only has a private overlay it will be used as the primary. BUG=7339 TEST=Ran setup_board, build_packages, and build_image on a board with only a private overlay (locally created). Ran setup_board, build_packages, and build_image on a board with both public and private overlays. Change-Id: Ic56e4951272ddb80511a213e3a2e54419267a49a Related Issues: http://codereview.chromium.org/3544009 http://codereview.chromium.org/3571015 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7efdebf

Patch Set 1 #

Patch Set 2 : Centralized logic for selecting primary overlays into cros_overlay_list #

Patch Set 3 : Removed requirement for a public variant overlay if a variant is specified #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -35 lines) Patch
M bin/cros_overlay_list View 1 2 3 chunks +70 lines, -33 lines 0 comments Download
M parallel_emerge View 1 2 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dave Parker
Related Issues: http://codereview.chromium.org/3544009 http://codereview.chromium.org/3571015
10 years, 2 months ago (2010-10-05 20:38:31 UTC) #1
Dave Parker
I've centralized logic for selecting a board's primary overlay into cros_overlay_list (per feedback). Note: I ...
10 years, 2 months ago (2010-10-06 23:20:36 UTC) #2
robotboy
cros_overlay_list: LGTM Thanks.
10 years, 2 months ago (2010-10-11 17:53:44 UTC) #3
Dave Parker
I've made an additional change to cros_overlay_list to support boards that have private variant overlays ...
10 years ago (2010-12-01 00:55:36 UTC) #4
robotboy
10 years ago (2010-12-01 01:41:54 UTC) #5
LGTM, thanks.

I tested by manually running to verify that the correct overlays will be
included for Seaboard and Dev Board.

Powered by Google App Engine
This is Rietveld 408576698