Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/full-codegen.h

Issue 3621013: Fix a bug in our handling of conditional expressions in test contexts. (Closed)
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/full-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 586 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 public: 597 public:
598 explicit TestContext(FullCodeGenerator* codegen, 598 explicit TestContext(FullCodeGenerator* codegen,
599 Label* true_label, 599 Label* true_label,
600 Label* false_label, 600 Label* false_label,
601 Label* fall_through) 601 Label* fall_through)
602 : ExpressionContext(codegen), 602 : ExpressionContext(codegen),
603 true_label_(true_label), 603 true_label_(true_label),
604 false_label_(false_label), 604 false_label_(false_label),
605 fall_through_(fall_through) { } 605 fall_through_(fall_through) { }
606 606
607 static const TestContext* cast(const ExpressionContext* context) {
608 ASSERT(context->IsTest());
609 return reinterpret_cast<const TestContext*>(context);
610 }
611
612 Label* true_label() const { return true_label_; }
613 Label* false_label() const { return false_label_; }
614 Label* fall_through() const { return fall_through_; }
615
607 virtual void Plug(bool flag) const; 616 virtual void Plug(bool flag) const;
608 virtual void Plug(Register reg) const; 617 virtual void Plug(Register reg) const;
609 virtual void Plug(Label* materialize_true, Label* materialize_false) const; 618 virtual void Plug(Label* materialize_true, Label* materialize_false) const;
610 virtual void Plug(Slot* slot) const; 619 virtual void Plug(Slot* slot) const;
611 virtual void Plug(Handle<Object> lit) const; 620 virtual void Plug(Handle<Object> lit) const;
612 virtual void Plug(Heap::RootListIndex) const; 621 virtual void Plug(Heap::RootListIndex) const;
613 virtual void PlugTOS() const; 622 virtual void PlugTOS() const;
614 virtual void DropAndPlug(int count, Register reg) const; 623 virtual void DropAndPlug(int count, Register reg) const;
615 virtual void EmitLogicalLeft(BinaryOperation* expr, 624 virtual void EmitLogicalLeft(BinaryOperation* expr,
616 Label* eval_right, 625 Label* eval_right,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 665
657 friend class NestedStatement; 666 friend class NestedStatement;
658 667
659 DISALLOW_COPY_AND_ASSIGN(FullCodeGenerator); 668 DISALLOW_COPY_AND_ASSIGN(FullCodeGenerator);
660 }; 669 };
661 670
662 671
663 } } // namespace v8::internal 672 } } // namespace v8::internal
664 673
665 #endif // V8_FULL_CODEGEN_H_ 674 #endif // V8_FULL_CODEGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698