Issue 3621013: Fix a bug in our handling of conditional expressions in test contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3621013: Fix a bug in our handling of conditional expressions in test contexts. (Closed)

Created:
10 years, 2 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Visibility:
Public.

Description

Fix a bug in our handling of conditional expressions in test contexts. In the FullCodeGenerator, we compile the true subexpression of a conditional (ternary) expression in the inherited context of the entire expression. This is correct for effect and value contexts, but not for test contexts where the context includes a possible fall-through label. Committed: http://code.google.com/p/v8/source/detail?r=5607

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	src/full-codegen.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	src/full-codegen.cc	View		1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages