Issue 362007: Centering the browser action badges better

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 362007: Centering the browser action badges better (Closed)

Created:
11 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Force the same even-ness between the badge and the icon. Otherwise, the badge looks off center. BUG=26400 TEST=I guess this is just a matter of eyeballing it. The badge should not look off-center when compared to the icon, even with different sized icons and different width of text in the badge. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30994

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	chrome/common/extensions/extension_action.cc	View		3 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hooray

lgtm

Expand Messages | Collapse Messages