Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/arm/debug-arm.cc

Issue 362003: Fix issue 491: constantpool dump violates ARM debugger assertion for return p... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/arm/fast-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 patcher.masm()->mov(v8::internal::lr, v8::internal::pc); 54 patcher.masm()->mov(v8::internal::lr, v8::internal::pc);
55 patcher.masm()->ldr(v8::internal::pc, MemOperand(v8::internal::pc, -4)); 55 patcher.masm()->ldr(v8::internal::pc, MemOperand(v8::internal::pc, -4));
56 patcher.Emit(Debug::debug_break_return()->entry()); 56 patcher.Emit(Debug::debug_break_return()->entry());
57 patcher.masm()->bkpt(0); 57 patcher.masm()->bkpt(0);
58 } 58 }
59 59
60 60
61 // Restore the JS frame exit code. 61 // Restore the JS frame exit code.
62 void BreakLocationIterator::ClearDebugBreakAtReturn() { 62 void BreakLocationIterator::ClearDebugBreakAtReturn() {
63 rinfo()->PatchCode(original_rinfo()->pc(), 63 rinfo()->PatchCode(original_rinfo()->pc(),
64 CodeGenerator::kJSReturnSequenceLength); 64 Debug::kARMJSReturnSequenceLength);
65 } 65 }
66 66
67 67
68 // A debug break in the exit code is identified by a call. 68 // A debug break in the exit code is identified by a call.
69 bool Debug::IsDebugBreakAtReturn(RelocInfo* rinfo) { 69 bool Debug::IsDebugBreakAtReturn(RelocInfo* rinfo) {
70 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode())); 70 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode()));
71 return rinfo->IsPatchedReturnSequence(); 71 return rinfo->IsPatchedReturnSequence();
72 } 72 }
73 73
74 74
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 // ----------------------------------- 204 // -----------------------------------
205 Generate_DebugBreakCallHelper(masm, 0); 205 Generate_DebugBreakCallHelper(masm, 0);
206 } 206 }
207 207
208 208
209 #undef __ 209 #undef __
210 210
211 #endif // ENABLE_DEBUGGER_SUPPORT 211 #endif // ENABLE_DEBUGGER_SUPPORT
212 212
213 } } // namespace v8::internal 213 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/arm/fast-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698