Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 3620013: AU: Resume interrupted update attempts. (Closed)

Created:
10 years, 2 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, adlr
Visibility:
Public.

Description

AU: Resume interrupted update attempts. BUG=7390, 7520 TEST=unit tests Change-Id: I9baf72aa444dd855409f865f03fb665e91f8d03d Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9b23057

Patch Set 1 #

Patch Set 2 : copyright and header fixes #

Patch Set 3 : update apply_delta #

Total comments: 2

Patch Set 4 : address review comments, rebase, add multi fetcher #

Patch Set 5 : fix setup download #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -56 lines) Patch
M delta_performer.h View 2 chunks +9 lines, -2 lines 0 comments Download
M delta_performer.cc View 7 chunks +57 lines, -8 lines 0 comments Download
M delta_performer_unittest.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M download_action.h View 1 chunk +2 lines, -0 lines 0 comments Download
M filesystem_copier_action.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M filesystem_copier_action_unittest.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M generate_delta_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M multi_http_fetcher.h View 5 chunks +10 lines, -9 lines 0 comments Download
M omaha_response_handler_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M update_attempter.h View 3 chunks +27 lines, -21 lines 0 comments Download
M update_attempter.cc View 1 2 3 4 9 chunks +37 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
petkov
This change enables resuming of interrupted updates by loading the appropriate state in DeltaPerformer and ...
10 years, 2 months ago (2010-10-07 21:04:17 UTC) #1
adlr
LGTM http://codereview.chromium.org/3620013/diff/4001/5008 File update_attempter.cc (right): http://codereview.chromium.org/3620013/diff/4001/5008#newcode260 update_attempter.cc:260: DeltaPerformer::ResetUpdateProgress(prefs_, false); should we maybe update prefs files ...
10 years, 2 months ago (2010-10-08 02:23:52 UTC) #2
petkov
Addressed comment, rebased and integrated with the multi fetcher. Unit tests pass. I need to ...
10 years, 2 months ago (2010-10-08 06:02:13 UTC) #3
adlr
LGTM! woohoo!
10 years, 2 months ago (2010-10-08 06:25:22 UTC) #4
adlr
LGTM
10 years, 2 months ago (2010-10-08 17:19:14 UTC) #5
petkov
10 years, 2 months ago (2010-10-08 17:21:04 UTC) #6
On 2010/10/08 17:19:14, adlr wrote:
> LGTM

Pushed... Let's test it now :-)

Powered by Google App Engine
This is Rietveld 408576698