Issue 362001: GTK: Properly convert task manager UI row to task manager model row....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 362001: GTK: Properly convert task manager UI row to task manager model row.... (Closed)

Created:
11 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, jam, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

GTK: Properly convert task manager UI row to task manager model row. Also clean up some leaking tree paths. BUG=22961 TEST=after sorting, task manager still works normally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30976

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	chrome/browser/gtk/task_manager_gtk.cc	View	1	3 chunks	+16 lines, -3 lines	0 comments	Download
	M	ipc/ipc_message.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Evan Stade

I spent a long time on a much more complicated solution that didn't even work ...

11 years, 1 month ago (2009-11-04 07:26:45 UTC) #1

LGTM.  Nice find on the leaks.