AU: Cyclebreaker optimization

AU: Cyclebreaker optimization

When using the cycle breaker, we know that operations that are full
(REPLACE, REPLACE_BZ) can't have any incoming edges, and thus can't be
in a cycle.

To help reduce CPU usage, change the cycle breaker to skip nodes that
are REPLACE or REPLACE_BZ.

BUG=7294
TEST=Attached unittests, generated delta update and applied it

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=182a9f5

[petkov, 2010-10-05 18:04:20]

One issue below, LGTM otherwise.

One could also add a unit test, for example, through
logging.h:SetLogMessageHandler and look for the skipped info message.

http://codereview.chromium.org/3618006/diff/1/2
File cycle_breaker.cc (right):

http://codereview.chromium.org/3618006/diff/1/2#newcode42
cycle_breaker.cc:42: op_type ==
DeltaArchiveManifest_InstallOperation_Type_REPLACE) {
you mean REPLACE_BZ here, right?

[adlr, 2010-10-05 23:34:15]

thanks. fixed, wrote unittest, and pushed

http://codereview.chromium.org/3618006/diff/1/2
File cycle_breaker.cc (right):

http://codereview.chromium.org/3618006/diff/1/2#newcode42
cycle_breaker.cc:42: op_type ==
DeltaArchiveManifest_InstallOperation_Type_REPLACE) {
On 2010/10/05 18:04:20, petkov wrote:
> you mean REPLACE_BZ here, right?
> 

ooo. i should have caught that. thanks. fixed.