Issue 3617002: AU: Fall back to full updates after a number of failed delta update attempts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3617002: AU: Fall back to full updates after a number of failed delta update attempts. (Closed)

Created:
10 years, 2 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Fall back to full updates after a number of failed delta update attempts. Count each failed delta update attempt. Keep the count in persistent storage. If the count exceeds a threshold (3), disable delta updates by setting delta_okay to false in the update check request. Once this CL is in, we have to ensure that we have a full update payload available on the update server for each version otherwise we may orphan clients. BUG=7221 TEST=unit tests, gmerged on device and tested with a mod'ed dev server Change-Id: I7f7fa73f652f12f22cc8604dad6a26c802b8582d Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3627577

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove leftover log #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -5 lines)			Patch
M	prefs.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	prefs_interface.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	update_attempter.h	View		4 chunks	+13 lines, -0 lines	0 comments	Download
M	update_attempter.cc	View	1	8 chunks	+36 lines, -1 line	0 comments	Download
M	update_attempter_unittest.cc	View		3 chunks	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM http://codereview.chromium.org/3617002/diff/1/4 File update_attempter.cc (right): http://codereview.chromium.org/3617002/diff/1/4#newcode322 update_attempter.cc:322: LOG(INFO) << "Marking"; better log message?

10 years, 2 months ago (2010-10-01 18:00:05 UTC) #2

petkov

10 years, 2 months ago (2010-10-01 18:04:25 UTC) #3

pushing soon...

http://codereview.chromium.org/3617002/diff/1/4
File update_attempter.cc (right):

http://codereview.chromium.org/3617002/diff/1/4#newcode322
update_attempter.cc:322: LOG(INFO) << "Marking";
On 2010/10/01 18:00:05, adlr wrote:
> better log message?

Removed -- this was a debug left over.

Expand Messages | Collapse Messages