Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 3614013: Don't use -fno-ident for Clang builds in Release mode on Linux. (Closed)

Created:
10 years, 2 months ago by hans
Modified:
9 years, 5 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Don't use -fno-ident for Clang builds in Release mode on Linux. It's not supported by Clang and causes a ton of "argument unused during compilation" warnings. BUG=none TEST=everything still builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hans
Those warnings have been annoying me for a while now. Please take a look as ...
10 years, 2 months ago (2010-10-08 15:58:53 UTC) #1
Evan Martin
10 years, 2 months ago (2010-10-08 16:20:01 UTC) #2
LGTM (never tried in release)

Powered by Google App Engine
This is Rietveld 408576698