Issue 3613007: Add a note warning the users that presubmit hooks will be run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3613007: Add a note warning the users that presubmit hooks will be run. (Closed)

Created:
10 years, 2 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Add a note warning the users that presubmit hooks will be run. Otherwise the scripts make it looks like they are hung when the presubmit checks are slow. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61506

Patch Set 1 #

Patch Set 2 : move the print to inner function and update tests #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	presubmit_support.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		5 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

10 years, 2 months ago (2010-10-04 19:50:20 UTC) #2

lg

On Mon, Oct 4, 2010 at 12:35 PM, <maruel@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Add a note warning the users that presubmit hooks will be run.
>
> Otherwise the scripts make it looks like they are hung when the presubmit
> checks
> are slow.
>
> TEST=none
> BUG=none
>
> Please review this at http://codereview.chromium.org/3613007/show
>
> Affected files:
>  M presubmit_support.py
>
>
> Index: presubmit_support.py
> diff --git a/presubmit_support.py b/presubmit_support.py
> index
>
c03c3eabf35d736b2702e8afc3f8f3a0d340bd81..f16ed6eecb183ba8bc66d1cb96f26059ccdff4ce
> 100755
> --- a/presubmit_support.py
> +++ b/presubmit_support.py
> @@ -1078,6 +1078,7 @@ def Main(argv):
>       print "Found %d files." % len(options.files)
>     else:
>       print "Found 1 file."
> +  print "Running presubmit hooks..."
>   return not DoPresubmitChecks(change_class(options.name,
>                                             options.description,
>                                             options.root,
>
>
>

Expand Messages | Collapse Messages