Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 3612004: Add board option to au test harness so that this works for others without a default board. (Closed)

Created:
10 years, 2 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add board option to au test harness so that this works for others without a default board and add ability to reference images without relative paths. Change-Id: I4afa86fa7a6b772124de56114910a1ca5e3d4511 BUG= TEST=Ran through update harness code and ran loman. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=af33f8f

Patch Set 1 #

Patch Set 2 : Add some more functions. #

Total comments: 1

Patch Set 3 : Reorder #

Patch Set 4 : Clean up board #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M bin/cros_au_test_harness.py View 1 2 3 6 chunks +11 lines, -2 lines 0 comments Download
M bin/loman.py View 2 chunks +2 lines, -12 lines 0 comments Download
M get_latest_image.sh View 1 chunk +1 line, -2 lines 0 comments Download
M lib/cros_build_lib.py View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
10 years, 2 months ago (2010-10-04 23:19:19 UTC) #1
petkov
10 years, 2 months ago (2010-10-04 23:39:54 UTC) #2
LGTM

http://codereview.chromium.org/3612004/diff/2001/3001
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/3612004/diff/2001/3001#newcode22
bin/cros_au_test_harness.py:22: global board
sort?

Powered by Google App Engine
This is Rietveld 408576698