Issue 3611014: Fix 57090: NTP apps sorted in random-looking order....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3611014: Fix 57090: NTP apps sorted in random-looking order.... (Closed)

Created:
10 years, 2 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, arv (Not doing code reviews), pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix 57090: NTP apps sorted in random-looking order. Add the concept of app_launch_index, stored with the extension that determines an install order which is used to order the apps on the new tab page. BUG=57090 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62112

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -0 lines)			Patch
M	chrome/browser/dom_ui/app_launcher_handler.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View	3 chunks	+36 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs_unittest.cc	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages