Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 361033: Fix bug 486, Cyrillic character ranges in case independent regexps.... (Closed)

Created:
11 years, 1 month ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix bug 486, Cyrillic character ranges in case independent regexps. http://code.google.com/p/v8/issues/detail?id=486 Committed: http://code.google.com/p/v8/source/detail?r=3236

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -5 lines) Patch
M src/jsregexp.cc View 1 3 chunks +42 lines, -5 lines 0 comments Download
A test/mjsunit/cyrillic.js View 1 chunk +169 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-486.js View 1 chunk +30 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Erik Corry
11 years, 1 month ago (2009-11-05 19:45:00 UTC) #1
Christian Plesner Hansen
Lgtm http://codereview.chromium.org/361033/diff/1/2 File test/mjsunit/regress/regress-486.js (right): http://codereview.chromium.org/361033/diff/1/2#newcode29 Line 29: var cyrillicMatch = /^[\u0430-\u044fa-z]+$/i.test(st); // a-ja a-z. ...
11 years, 1 month ago (2009-11-06 08:27:59 UTC) #2
Erik Corry
On 2009/11/06 08:27:59, Christian Plesner Hansen wrote: > Lgtm > > http://codereview.chromium.org/361033/diff/1/2 > File test/mjsunit/regress/regress-486.js ...
11 years, 1 month ago (2009-11-06 10:24:26 UTC) #3
Christian Plesner Hansen
Lgtm http://codereview.chromium.org/361033/diff/4001/4002 File test/mjsunit/regress/regress-486.js (right): http://codereview.chromium.org/361033/diff/4001/4002#newcode29 Line 29: var cyrillicMatch = /^[\u0430-\u044fa-z]+$/i.test(st); // a-ja a-z. ...
11 years, 1 month ago (2009-11-06 10:36:09 UTC) #4
Erik Corry
http://codereview.chromium.org/361033/diff/4001/4002 File test/mjsunit/regress/regress-486.js (right): http://codereview.chromium.org/361033/diff/4001/4002#newcode29 Line 29: var cyrillicMatch = /^[\u0430-\u044fa-z]+$/i.test(st); // a-ja a-z. On ...
11 years, 1 month ago (2009-11-06 11:15:18 UTC) #5
Christian Plesner Hansen
11 years, 1 month ago (2009-11-06 11:21:30 UTC) #6
Ah, indeed you did.

Powered by Google App Engine
This is Rietveld 408576698