Fix checkfailure on Linux Views build by actually opening the popup when it's...

Fix checkfailure on Linux Views build by actually opening the popup when it's initted.

Also add sanity checking like in the Windows version.

BUG=20511
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31119

[Peter Kasting, 2009-11-05 01:10:44]

Was the Linux popup not opening when Init() was called (which is what it looks
like)?  If so perhaps this will fix it.

[oshima, 2009-11-05 02:01:18]

http://codereview.chromium.org/361020/diff/1/3
File chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc (left):

http://codereview.chromium.org/361020/diff/1/3#oldcode44
Line 44: if (!IsVisible()) {
Why did you remove this condition? is this necessary?

[Peter Kasting, 2009-11-05 02:04:14]

http://codereview.chromium.org/361020/diff/1/3
File chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc (left):

http://codereview.chromium.org/361020/diff/1/3#oldcode44
Line 44: if (!IsVisible()) {
On 2009/11/05 02:01:18, oshima wrote:
> Why did you remove this condition? is this necessary?

Shouldn't these two calls be harmless when the widget is already visible?

[oshima, 2009-11-05 19:04:09]

http://codereview.chromium.org/361020/diff/1/3
File chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc (left):

http://codereview.chromium.org/361020/diff/1/3#oldcode44
Line 44: if (!IsVisible()) {
On 2009/11/05 02:04:14, Peter Kasting wrote:
> On 2009/11/05 02:01:18, oshima wrote:
> > Why did you remove this condition? is this necessary?
> 
> Shouldn't these two calls be harmless when the widget is already visible?

It depends on what "harmless" really means. Looks like Show() is probably no-op,
but StackPopupShow does some work (issues XQuery to server for example), which
is probably a waste? If you feel strongly about it, some explain would help.

[Peter Kasting, 2009-11-05 19:11:31]

http://codereview.chromium.org/361020/diff/1/3
File chrome/browser/views/autocomplete/autocomplete_popup_gtk.cc (left):

http://codereview.chromium.org/361020/diff/1/3#oldcode44
Line 44: if (!IsVisible()) {
On 2009/11/05 19:04:09, oshima wrote:
> StackPopupShow does some work (issues XQuery to server for example), which
> is probably a waste? If you feel strongly about it, some explain would help.

Does anyone care?  It's not as if this is perf-critical code in an inner loop. 
Seemed like the simpler code was more beneficial than trying to avoid an X call.

It's not worth arguing about, so I'll change it back.

[Peter Kasting, 2009-11-05 19:13:48]

Here, this version also reverts the similar change I had already made in the
Windows code.

[oshima, 2009-11-05 19:33:01]

LGTM

Thanks!


On 2009/11/05 19:13:48, Peter Kasting wrote:
> Here, this version also reverts the similar change I had already made in the
> Windows code.