Issue 361011: Clean up bookmark_editor_controller to so that is closes consistently as both...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 361011: Clean up bookmark_editor_controller to so that is closes consistently as both... (Closed)

Created:
11 years, 1 month ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Clean up bookmark_editor_controller to so that is closes consistently as both a standard window and as a sheet. Get rid of an unneeded member variable. Clean up unittest to use new CocoaTest, and to clean up its windows properly. BUG=none TEST=Open the bookmark editing window and edit bookmarks. Make sure to test with both OK and Cancel. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31000

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -78 lines)			Patch
M	chrome/browser/cocoa/bookmark_editor_controller.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_controller.mm	View		4 chunks	+14 lines, -20 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_controller_unittest.mm	View	1	9 chunks	+73 lines, -57 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmac

Mind taking a look at this? It's actually blocking me getting my autorelease fixes in.

11 years, 1 month ago (2009-11-04 20:48:54 UTC) #1

Also LGTM

Expand Messages | Collapse Messages