Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/arm/fast-codegen-arm.cc

Issue 361005: Fix compilation error in debug build for IA-32 and ARM. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/fast-codegen-ia32.cc » ('j') | src/ia32/fast-codegen-ia32.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 Label check_exit_codesize; 123 Label check_exit_codesize;
124 masm_->bind(&check_exit_codesize); 124 masm_->bind(&check_exit_codesize);
125 #endif 125 #endif
126 CodeGenerator::RecordPositions(masm_, position); 126 CodeGenerator::RecordPositions(masm_, position);
127 __ RecordJSReturn(); 127 __ RecordJSReturn();
128 __ mov(sp, fp); 128 __ mov(sp, fp);
129 __ ldm(ia_w, sp, fp.bit() | lr.bit()); 129 __ ldm(ia_w, sp, fp.bit() | lr.bit());
130 int num_parameters = function_->scope()->num_parameters(); 130 int num_parameters = function_->scope()->num_parameters();
131 __ add(sp, sp, Operand((num_parameters + 1) * kPointerSize)); 131 __ add(sp, sp, Operand((num_parameters + 1) * kPointerSize));
132 __ Jump(lr); 132 __ Jump(lr);
133 }
134 #ifdef DEBUG 133 #ifdef DEBUG
135 // Check that the size of the code used for returning matches what is 134 // Check that the size of the code used for returning matches what is
136 // expected by the debugger. The add instruction above is an addressing 135 // expected by the debugger. The add instruction above is an addressing
137 // mode 1 instruction where there are restrictions on which immediate values 136 // mode 1 instruction where there are restrictions on which immediate values
138 // can be encoded in the instruction and which immediate values requires 137 // can be encoded in the instruction and which immediate values requires
139 // use of an additional instruction for moving the immediate to a temporary 138 // use of an additional instruction for moving the immediate to a temporary
140 // register. 139 // register.
141 int expected_return_sequence_length = CodeGenerator::kJSReturnSequenceLength; 140 int expected_return_sequence_length = CodeGenerator::kJSReturnSequenceLength;
142 if (!masm_->ImmediateFitsAddrMode1Instruction((num_parameters + 1) * 141 if (!masm_->ImmediateFitsAddrMode1Instruction((num_parameters + 1) *
143 kPointerSize)) { 142 kPointerSize)) {
144 // Additional mov instruction generated. 143 // Additional mov instruction generated.
145 expected_return_sequence_length++; 144 expected_return_sequence_length++;
146 } 145 }
147 ASSERT_EQ(expected_return_sequence_length, 146 ASSERT_EQ(expected_return_sequence_length,
148 masm_->InstructionsGeneratedSince(&check_exit_codesize)); 147 masm_->InstructionsGeneratedSince(&check_exit_codesize));
149 #endif 148 #endif
149 }
150 } 150 }
151 151
152 152
153 void FastCodeGenerator::Move(Expression::Context context, Register source) { 153 void FastCodeGenerator::Move(Expression::Context context, Register source) {
154 switch (context) { 154 switch (context) {
155 case Expression::kUninitialized: 155 case Expression::kUninitialized:
156 UNREACHABLE(); 156 UNREACHABLE();
157 case Expression::kEffect: 157 case Expression::kEffect:
158 break; 158 break;
159 case Expression::kValue: 159 case Expression::kValue:
(...skipping 1127 matching lines...) Expand 10 before | Expand all | Expand 10 after
1287 true_label_ = saved_true; 1287 true_label_ = saved_true;
1288 false_label_ = saved_false; 1288 false_label_ = saved_false;
1289 // Convert current context to test context: End post-test code. 1289 // Convert current context to test context: End post-test code.
1290 } 1290 }
1291 1291
1292 1292
1293 #undef __ 1293 #undef __
1294 1294
1295 1295
1296 } } // namespace v8::internal 1296 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/fast-codegen-ia32.cc » ('j') | src/ia32/fast-codegen-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698