Issue 361005: Fix compilation error in debug build for IA-32 and ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 361005: Fix compilation error in debug build for IA-32 and ARM. (Closed)

Created:
11 years, 1 month ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix compilation error in debug build for IA-32 and ARM. TBR=sgjesse@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=3214

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/arm/fast-codegen-arm.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	src/ia32/fast-codegen-ia32.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 1 month ago (2009-11-04 14:40:04 UTC) #3

Minor comment after all - you can fix that next time you touch the file.

http://codereview.chromium.org/361005/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/361005/diff/1/2#newcode33
Line 33: #include "debug.h"
Please keep the include files sorted by name.

Expand Messages | Collapse Messages