Issue 361003: Fix BlacklistManagerBrowserTest.Basic to be more solid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 361003: Fix BlacklistManagerBrowserTest.Basic to be more solid. (Closed)

Created:
11 years, 1 month ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix BlacklistManagerBrowserTest.Basic to be more solid. It turns out it was flaky (was waiting for an event that already happened). When running the message loop to wait for extension loading changes, it was executing BlacklistManager tasks as well. TEST=Covered by browser_tests. BUG=21541 TBR=aa Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30954

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc	View		1 chunk	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

11 years, 1 month ago (2009-11-04 14:12:54 UTC) #1

TBR

Generally I plan to create functions to make the waiting easier, but I have yet
to write more tests for that to see which functions would be most useful.

Expand Messages | Collapse Messages