Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 361002: Add support for getting the real process id from within the suid sandbox. The... (Closed)

Created:
11 years, 1 month ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), ben+cc_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add support for getting the real process id from within the suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox. While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox. Original review: http://codereview.chromium.org/262020 This is try 2 - initialize the sandbox host and zygote for InProcessBrowserTest. TBR=agl BUG=20012, 20714, 23072 TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -80 lines) Patch
M base/linux_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 6 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_sandbox_host_linux.h View 3 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_sandbox_host_linux.cc View 12 chunks +66 lines, -14 lines 0 comments Download
M chrome/browser/zygote_host_linux.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/zygote_host_linux.cc View 7 chunks +70 lines, -23 lines 0 comments Download
M chrome/browser/zygote_main_linux.cc View 10 chunks +107 lines, -26 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/sandbox_methods_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
Only change between this and the original CL is in chrome/test/in_process_browser_test.cc. I didn't try the ...
11 years, 1 month ago (2009-11-04 08:30:42 UTC) #1
agl
11 years, 1 month ago (2009-11-04 16:22:33 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698