Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: printing/emf_win_unittest.cc

Issue 3610013: Printing: Convert PrintingContext into an interface implemented by the separate (Closed)
Patch Set: Comment cleanup only. Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_job_worker.cc ('k') | printing/printing.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/emf_win_unittest.cc
diff --git a/printing/emf_win_unittest.cc b/printing/emf_win_unittest.cc
index 4c1247b99e3fda1db55199e0b8f224c11dfdbed3..bfd56b86a30edb172e969a16ed8ba260c5c52f7d 100644
--- a/printing/emf_win_unittest.cc
+++ b/printing/emf_win_unittest.cc
@@ -13,6 +13,7 @@
#include "base/file_util.h"
#include "base/path_service.h"
#include "base/scoped_handle_win.h"
+#include "base/scoped_ptr.h"
#include "printing/printing_context.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -75,8 +76,9 @@ TEST_F(EmfPrintingTest, Enumerate) {
settings.set_device_name(L"UnitTest Printer");
// Initialize it.
- printing::PrintingContext context;
- EXPECT_EQ(context.InitWithSettings(settings), printing::PrintingContext::OK);
+ scoped_ptr<printing::PrintingContext> context(
+ printing::PrintingContext::Create());
+ EXPECT_EQ(context->InitWithSettings(settings), printing::PrintingContext::OK);
FilePath emf_file;
EXPECT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &emf_file));
@@ -95,10 +97,10 @@ TEST_F(EmfPrintingTest, Enumerate) {
// unit_test, printing::PrintingContext automatically dumps its files to the
// current directory.
// TODO(maruel): Clean the .PRN file generated in current directory.
- context.NewDocument(L"EmfTest.Enumerate");
- context.NewPage();
+ context->NewDocument(L"EmfTest.Enumerate");
+ context->NewPage();
// Process one at a time.
- printing::Emf::Enumerator emf_enum(emf, context.context(),
+ printing::Emf::Enumerator emf_enum(emf, context->context(),
&emf.GetBounds().ToRECT());
for (printing::Emf::Enumerator::const_iterator itr = emf_enum.begin();
itr != emf_enum.end();
@@ -111,8 +113,8 @@ TEST_F(EmfPrintingTest, Enumerate) {
EXPECT_TRUE(itr->SafePlayback(NULL)) <<
" index: " << index << " type: " << itr->record()->iType;
}
- context.PageDone();
- context.DocumentDone();
+ context->PageDone();
+ context->DocumentDone();
}
// Disabled if no "UnitTest printer" exists.
« no previous file with comments | « chrome/browser/printing/print_job_worker.cc ('k') | printing/printing.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698