DescriptionWhile changing the label class I added a DCHECK to
make sure the function I was changing was never
called for multiline labels (it never was supposed
to work for multiline labels, even before my change).
Turns out, this flushed out a caller who calls it
for multiline labels, and gets the wrong results.
BUG=None
TEST=Trigger a javascript alert with multiple lines.
Make sure no DCHECK happens. If you set a breakpoint
on the function I'm changing and hover over the label,
when you step through the code, you'll see that it now
correctly computes the bounds of the label based on
the width and calls SetContainsMouse with true
instead of false.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30993
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|