Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 361001: While changing the label class I added a DCHECK to make sure the function... (Closed)

Created:
11 years, 1 month ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

While changing the label class I added a DCHECK to make sure the function I was changing was never called for multiline labels (it never was supposed to work for multiline labels, even before my change). Turns out, this flushed out a caller who calls it for multiline labels, and gets the wrong results. BUG=None TEST=Trigger a javascript alert with multiple lines. Make sure no DCHECK happens. If you set a breakpoint on the function I'm changing and hover over the label, when you step through the code, you'll see that it now correctly computes the bounds of the label based on the width and calls SetContainsMouse with true instead of false. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M views/controls/label.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
11 years, 1 month ago (2009-11-04 06:08:47 UTC) #1
DaveMoore
11 years, 1 month ago (2009-11-04 19:37:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698