Issue 3609008: Make lint happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3609008: Make lint happy. (Closed)

Created:
10 years, 2 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Make lint happy. TBR=kmillikin@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=5585

Patch Set 1 #

Total comments: 2

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	src/x64/codegen-x64.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

http://codereview.chromium.org/3609008/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/3609008/diff/1/2#newcode194 src/ia32/codegen-ia32.cc:194: { // NOLINT I'd rather that we move the ...

10 years, 2 months ago (2010-10-05 08:38:22 UTC) #2

Vitaly Repeshko

10 years, 2 months ago (2010-10-05 10:23:52 UTC) #3

Mads,

Kevin fixed this the right way. He hasn't submitted his fix yet.


Thanks,
Vitaly

Expand Messages | Collapse Messages