presubmit_canned_checks.py - Issue 3609007: Don't check number of pending builds for offline builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 3609007: Don't check number of pending builds for offline builders. (Closed)

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index a5b28f1e0842a6081da87de677ea1daf045ba5c7..014af28ae2fdd176f4ee27d335417f87939ca5b5 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -516,6 +516,8 @@ def CheckBuildbotPendingBuilds(input_api, output_api, url, max_pendings,

for (builder_name, builder) in data.iteritems():

if builder_name in ignored:

continue

+ if builder.get('state', '') == 'offline':

+ continue

pending_builds_len = len(builder.get('pending_builds', []))

if pending_builds_len > max_pendings:

out.append('%s has %d build(s) pending' %

« no previous file with comments | « no previous file | no next file » | no next file with comments »