Issue 3609007: Don't check number of pending builds for offline builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3609007: Don't check number of pending builds for offline builders. (Closed)

Created:
10 years, 2 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Don't check number of pending builds for offline builders. TEST=none BUG=29953 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61371

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

10 years, 2 months ago (2010-10-04 15:04:20 UTC) #2

lg

On Mon, Oct 4, 2010 at 7:24 AM, <maruel@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Don't check number of pending builds for offline builders.
>
> TEST=none
> BUG=29953
>
> Please review this at http://codereview.chromium.org/3609007/show
>
> Affected files:
>  M presubmit_canned_checks.py
>
>
> Index: presubmit_canned_checks.py
> diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
> index
>
a5b28f1e0842a6081da87de677ea1daf045ba5c7..014af28ae2fdd176f4ee27d335417f87939ca5b5
> 100644
> --- a/presubmit_canned_checks.py
> +++ b/presubmit_canned_checks.py
> @@ -516,6 +516,8 @@ def CheckBuildbotPendingBuilds(input_api, output_api,
> url, max_pendings,
>   for (builder_name, builder) in data.iteritems():
>     if builder_name in ignored:
>       continue
> +    if builder.get('state', '') == 'offline':
> +      continue
>     pending_builds_len = len(builder.get('pending_builds', []))
>     if pending_builds_len > max_pendings:
>       out.append('%s has %d build(s) pending' %
>
>
>

Expand Messages | Collapse Messages