Issue 3609002: Fix bug where we did not remember most visited section being closed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3609002: Fix bug where we did not remember most visited section being closed (Closed)

Created:
10 years, 2 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Fix bug where we did not remember most visited section being closed in the case where no apps are installed. BUG=56867 TEST=Have no apps installed. Open NTP. Hide MV section. Open another NTP. MV section should be hidden. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61116

Patch Set 1 #

Total comments: 1

Patch Set 2 : different approach #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/ntp/apps.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

LG with comment addressed Are there any unit tests for the NTP? Should there be? ...

10 years, 2 months ago (2010-09-30 21:12:46 UTC) #2

Aaron Boodman

10 years, 2 months ago (2010-09-30 21:22:49 UTC) #3

On 2010/09/30 21:12:46, Nico wrote:
> LG with comment addressed
> 
> Are there any unit tests for the NTP?

Not really. There are a few high-level tests in
chrome/browser/dom_ui/new_tab_ui_uitest.cc.

> Should there be?

Yes.

> http://codereview.chromium.org/3609002/diff/1/2
> File chrome/browser/resources/ntp/apps.js (right):
> 
> http://codereview.chromium.org/3609002/diff/1/2#newcode15
> chrome/browser/resources/ntp/apps.js:15: if (shownSections == Section.APPS)
> shownSections & Section.APPS

Thanks. On second thought, I think this was being too clever. There is no reason
to change the user's configuration when uninstalling the last app. I changed it
to just relayout instead.

Expand Messages | Collapse Messages